Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup some release issues edition 2 #72

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Fixup some release issues edition 2 #72

merged 4 commits into from
Oct 23, 2023

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Oct 22, 2023 •
edited
Loading

  • Rename the release workflow
  • Fixup the upload path in the release upload job
  • Adds one missing CHANGELOG entry
  • Drop tx version in the file names

@bkchr bkchr force-pushed the bkchr-fixup-release-edition-2 branch from e6c11b5 to 008cb46 Compare October 22, 2023 08:28
ggwpez
ggwpez approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release notes still mention Statemint and Statemine.

@bkchr
Copy link
Contributor Author

bkchr commented Oct 22, 2023

The release notes still mention Statemint and Statemine.

Should be done here: #71

@liamaharon
Copy link
Contributor

The release notes still mention Statemint and Statemine.

Should be done here: #71

Are you thinking I should just fix the specnames in my PR (breaking change) or add special handing in the release script for statemint and statemine?

@bkchr
Copy link
Contributor Author

bkchr commented Oct 23, 2023

/merge

@github-actions
Copy link

There was a problem running the action.

❌😵❌

Please find more information in the logs.

@bkchr bkchr merged commit 94b2798 into main Oct 23, 2023
8 checks passed
@github-actions
Copy link

There was a problem running the action.

❌😵❌

Please find more information in the logs.

@bkchr bkchr deleted the bkchr-fixup-release-edition-2 branch October 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresilva andresilva andresilva approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@ordian ordian ordian approved these changes

@bkontur bkontur bkontur approved these changes

@ggwpez ggwpez ggwpez approved these changes

@joepetrowski joepetrowski joepetrowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bkchr @liamaharon @andresilva @shawntabrizi @ordian @bkontur @ggwpez @joepetrowski