Add TSX support for <script type="tsx"> #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, TSX wasn't being highlighted as when in typescript it requires the language to be `typescriptreact`, not `typescript`. I've changed it so that the `typescript` matcher no longer matches `type="tsx"`, and there's a new matcher to handle that. Honestly I have absolutely no idea what's going on in that regex so might have got something wrong. I've manually tested the expression against a few different script type types but don't 100% understand the intention of the original expression (which also matches `type="tshelloworld"`).
|
unless i'm missing something, the test failure is totally unrelated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TSX wasn't being highlighted as when in typescript it requires the language to be
typescriptreact, nottypescript.I've changed it so that the
typescriptmatcher no longer matchestype="tsx", and there's a new matcher to handle that.Honestly I have absolutely no idea what's going on in that regex so might have got something wrong. I've manually tested the expression against a few different script type types but don't 100% understand the intention of the original expression (which also matches
type="tshelloworld").