Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-instantiate AssertionError under Node v8 (and v7) #26

Merged
merged 4 commits into from
Jun 9, 2017
Merged

Re-instantiate AssertionError under Node v8 (and v7) #26

merged 4 commits into from
Jun 9, 2017

Commits on Jun 8, 2017

  1. fix: recreate AssertionError under Node v8,v7 and if message is modified 

    when `modifyMessageOnRethrow` option is truthy.
since Node v8 (and v7) does not update message on rethrow.

refs power-assert-js/power-assert#85
    @twada
    twada committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    f34b6e7 View commit details
    Browse the repository at this point in the history

  2. refactor: refine regex for more accurate feature detection

    @twada
    twada committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    5004709 View commit details
    Browse the repository at this point in the history

  3. refactor: recreate AssertionError if necessary 

    recreate AssertionError when config.modifyMessageOnRethrow is false but config.saveContextOnRethrow is true
    @twada
    twada committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    f0aad9e View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2017

  1. test: err.stack isn't changed unless message is replaced

    @twada
    twada committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    3b25928 View commit details
    Browse the repository at this point in the history