allow fieldset with custom data-fields template #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like a form template, this pull allows a fieldset to have a custom template that includes `data-fields="<subset of fields in fieldset>"`
|
|
||
| //include all keys if not specified | ||
| if (!keys.length) | ||
| keys = _.keys(fields); |
There was a problem hiding this comment.
These if statements without curly braces don't pass jslint. I realize there are a lot of brace-less if statements in this project, but I think it would be best to use them moving forward.
|
@reustle cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like a form template, this pull allows a fieldset to have a custom template that includes
data-fields="<subset of fields in fieldset>"