Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in a doc #218

Closed
wants to merge 1 commit into from
Closed

Fix typo in a doc #218

wants to merge 1 commit into from

Conversation

niku
Copy link

@niku niku commented Mar 4, 2019

No description provided.

@RobertDober
Copy link
Collaborator

Thank you for your PR, actually this is not a typo, I use iff in this sense: https://www.merriam-webster.com/dictionary/iff

@niku
Copy link
Author

niku commented Mar 4, 2019

Oh, thank you.
I haven't known that word 😭

Thank you for your fast and kind answer.
I'll close the PR.

@niku niku closed this Mar 4, 2019
@niku niku deleted the patch-1 branch March 4, 2019 09:22
@RobertDober
Copy link
Collaborator

RobertDober commented Mar 4, 2019

I have not closed the PR because I thought that maybe iff is not such a good idea.

On one hand it is a precise way, but if unknown by many, maybe replacing iff by a clearer if and only if, or exactly if might be a good idea,

Using English only,nmaybe we should express ourselves in a simpler way, what do you think?

@niku
Copy link
Author

niku commented Mar 5, 2019

I agree with your thoughts.

My opinion is using if and only if makes the document be better.

It is a little bit verbose for some people.
But it is easier to grab what the words mean for non-native English reader like me.

@RobertDober
Copy link
Collaborator

Thank you for your feedback, here we go e65fcf6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants