Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow metadata in the ast passed into the transformer #288

Closed
RobertDober opened this issue Sep 24, 2019 · 0 comments
Closed

Allow metadata in the ast passed into the transformer #288

RobertDober opened this issue Sep 24, 2019 · 0 comments

Comments

@RobertDober
Copy link
Collaborator

RobertDober commented Sep 24, 2019

The idea is to adapt Earmark.Transform.transform to accept not only the types emitted by Earmark.to_ast but also tuples of the form {binary|:comment, list, list, %{custom:, _}}

This has two benefits

  • It would still allow to extend the ast, e.g. by adding a meta key to the map (e.g. to solve the html tag problem The _HTML Problem_ in the AST #289)
  • It allows filters to pass in a filtered / modified ast without an unnecessary and potentially costy cleanup run.
@RobertDober RobertDober self-assigned this Sep 24, 2019
RobertDober added a commit that referenced this issue Sep 27, 2019
RobertDober added a commit that referenced this issue Sep 27, 2019
…form WIP [amend-me]

  - Some tests with manually annotated ast transformations
@RobertDober RobertDober added this to the 1.4.2 milestone Oct 1, 2019
RobertDober added a commit that referenced this issue Oct 14, 2019
…form WIP [amend-me]

  - Some tests with manually annotated ast transformations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant