Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove JSON since the hook breaks ipynb files #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

njzjz
Copy link

@njzjz njzjz commented Oct 2, 2024

Clang-format 19 breaks ipynb files. xref: llvm/llvm-project#110727 I can't find a way to exclude a format in pre-commit-mirror, so I remove the JSON format directly to ensure the hook doesn't break any files with the default configuration.

Clang-format 19 breaks ipynb files. xref: llvm/llvm-project#110727 I can't find a way to exclude a format in pre-commit-mirror, so I remove the JSON format directly to ensure the hook doesn't break any files with the default configuration.
@asottile
Copy link
Member

asottile commented Oct 2, 2024

seems best for now to just override this in your own config (probably with exclude: ?) assuming this will get fixed upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants