Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing the requirements-txt-fixer #960 #967

Closed
wants to merge 1 commit into from

Conversation

j3962
Copy link

@j3962 j3962 commented Sep 27, 2023

Hey Anthony!

I have updated the requirements_txt_fixer.py to remove duplicate entries in the requirements file as per the bug in #960

Hope this helps!
Jay

@asottile
Copy link
Member

hi @JaySharmaSdsu -- you'll need to add a test to demonstrate your changes -- you'll also need to make sure the current testsuite continues to work

@j3962
Copy link
Author

j3962 commented Sep 28, 2023

Hmm, interesting! Let me do that then! Will ping you if I need any help. Those pytest file look confusing as a newbie!

@csibe17
Copy link

csibe17 commented Nov 8, 2023

hey @JaySharmaSdsu
what is the status of this PR?
can you please finish it?

@j3962
Copy link
Author

j3962 commented Nov 15, 2023

Hey @csibe17!
Sorry for the delay!
I will make sure to finish it off before the end of this week!

Thank you for your patience!

@asottile
Copy link
Member

asottile commented Apr 6, 2024

this ended up getting solved in #1014

@asottile asottile closed this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants