Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 10.8 changes #3589

Merged
merged 17 commits into from
Jun 24, 2022
Merged

Backport 10.8 changes #3589

merged 17 commits into from
Jun 24, 2022

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Jun 24, 2022 •
edited
Loading

No description provided.

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -1% - +0% (-0.76ms - +0.40ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +3% (-0.15ms - +1.33ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -2% - +2% (-26.55ms - +24.11ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -5% - +2% (-60.58ms - +28.51ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +16% (-2.71ms - +26.70ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +8% (-31.49ms - +56.13ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -5% - +6% (-15.22ms - +21.30ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -0% - +2% (-0.19ms - +0.94ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.05ms - +0.02ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.00ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • todo: unsure 🔍 -3% - +2% (-0.04ms - +0.02ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master115.70ms - 116.47ms-unsure 🔍
-0% - +1%
-0.40ms - +0.76ms
preact-local115.48ms - 116.34msunsure 🔍
-1% - +0%
-0.76ms - +0.40ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.16ms - 4.17ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local4.16ms - 4.17msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master49.14ms - 50.08ms-unsure 🔍
-2% - +1%
-0.82ms - +0.59ms
preact-local49.20ms - 50.25msunsure 🔍
-1% - +2%
-0.59ms - +0.82ms		-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master60.50ms - 63.32ms-unsure 🔍
-2% - +5%
-0.98ms - +3.01ms
preact-local59.49ms - 62.30msunsure 🔍
-5% - +2%
-3.01ms - +0.98ms		-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master54.14ms - 56.02ms-unsure 🔍
-2% - +3%
-1.19ms - +1.67ms
preact-local53.76ms - 55.92msunsure 🔍
-3% - +2%
-1.67ms - +1.19ms		-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master115.72ms - 116.49ms-unsure 🔍
-0% - +1%
-0.40ms - +0.75ms
preact-local115.50ms - 116.36msunsure 🔍
-1% - +0%
-0.75ms - +0.40ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master46.84ms - 47.89ms-unsure 🔍
-3% - +0%
-1.33ms - +0.15ms
preact-local47.43ms - 48.47msunsure 🔍
-0% - +3%
-0.15ms - +1.33ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.19ms - 4.20ms-unsure 🔍
-0% - +0%
-0.00ms - +0.01ms
preact-local4.19ms - 4.20msunsure 🔍
-0% - +0%
-0.01ms - +0.00ms		-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1248.89ms - 1289.54ms-unsure 🔍
-2% - +2%
-24.11ms - +26.55ms
preact-local1252.88ms - 1283.11msunsure 🔍
-2% - +2%
-26.55ms - +24.11ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master28.31ms - 28.36ms-unsure 🔍
-0% - +0%
-0.02ms - +0.05ms
preact-local28.30ms - 28.35msunsure 🔍
-0% - +0%
-0.05ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1255.12ms - 1322.08ms-unsure 🔍
-2% - +5%
-28.51ms - +60.58ms
preact-local1243.18ms - 1301.95msunsure 🔍
-5% - +2%
-60.58ms - +28.51ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master2.09ms - 2.11ms-unsure 🔍
-0% - +1%
-0.01ms - +0.01ms
preact-local2.09ms - 2.10msunsure 🔍
-1% - +0%
-0.01ms - +0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master155.28ms - 175.86ms-unsure 🔍
-15% - +1%
-26.70ms - +2.71ms
preact-local167.05ms - 188.07msunsure 🔍
-2% - +16%
-2.71ms - +26.70ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.92ms - 6.92ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local6.91ms - 6.92msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master660.22ms - 718.72ms-unsure 🔍
-8% - +4%
-56.13ms - +31.49ms
preact-local669.17ms - 734.41msunsure 🔍
-5% - +8%
-31.49ms - +56.13ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master5.72ms - 5.73ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-local5.72ms - 5.73msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master316.45ms - 342.44ms-unsure 🔍
-6% - +5%
-21.30ms - +15.22ms
preact-local319.65ms - 345.32msunsure 🔍
-5% - +6%
-15.22ms - +21.30ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.31ms - 1.31ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local1.31ms - 1.31msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
todo

duration

VersionAvg timevs preact-mastervs preact-local
preact-master45.18ms - 45.80ms-unsure 🔍
-2% - +0%
-0.94ms - +0.19ms
preact-local45.40ms - 46.34msunsure 🔍
-0% - +2%
-0.19ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.35ms - 1.39ms-unsure 🔍
-2% - +3%
-0.02ms - +0.04ms
preact-local1.34ms - 1.38msunsure 🔍
-3% - +2%
-0.04ms - +0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions
Copy link

github-actions bot commented Jun 24, 2022 •
edited
Loading

Size Change: -439 B (1%)

Total Size: 38 kB

Filename Size Change
compat/dist/compat.js 3.6 kB -33 B (0%)
compat/dist/compat.umd.js 3.68 kB -29 B (0%)
debug/dist/debug.js 3.08 kB -166 B (5%) ✅
debug/dist/debug.umd.js 3.17 kB -160 B (5%) ✅
dist/preact.js 4.7 kB -2 B (0%)
dist/preact.min.js 4.75 kB -3 B (0%)
dist/preact.umd.js 4.78 kB +1 B
hooks/dist/hooks.js 1.29 kB -33 B (2%)
hooks/dist/hooks.umd.js 1.38 kB -26 B (1%)
test-utils/dist/testUtils.js 437 B +6 B (1%)
test-utils/dist/testUtils.umd.js 522 B +6 B (1%)
ℹ️ View Unchanged
Filename Size Change
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.umd.js 316 B 0 B
jsx-runtime/dist/jsxRuntime.js 342 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 425 B 0 B
server/dist/server.js 2.6 kB 0 B
server/dist/server.umd.js 2.69 kB 0 B

compressed-size-action

@coveralls
Copy link

coveralls commented Jun 24, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 99.44% when pulling c7a46c9 on backport into 730604e on main.

@JoviDeCroock JoviDeCroock marked this pull request as ready for review June 24, 2022 19:36
@JoviDeCroock JoviDeCroock mentioned this pull request Jun 24, 2022
Closed
developit
developit approved these changes Jun 24, 2022
View reviewed changes
Copy link
Member

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! I didn't realize we had landed queueMicrotask lol

@JoviDeCroock JoviDeCroock merged commit d269b75 into main Jun 24, 2022
@JoviDeCroock JoviDeCroock deleted the backport branch June 24, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developit developit developit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoviDeCroock @coveralls @developit