- Removed vnode arg to mount
- Fixed up mounting with linked list
- Use _index property on internal to track null holes in children

Co-authored-by: Jovi De Croock <[email protected]>
Co-authored-by: Jason Miller <[email protected]>
Co-authored-by: Marvin Hagemeister <[email protected]>

After running into problems with the 'should move multiple keyed children to the beginning' test with the previous commit, we are switching our insertion loop to iterate backwards through the internal children to do insertions.

In summary:
First loop:
- find matching internals (using if _prev pointer is set to determine if an internal has been used)
- setup _prev pointers to be correct

Second loop:
- setup _next pointers to be correct
- insert or mount dom children (detect if a node was moved by comparing if internal._prev._next == internal)

There are still bugs though but above is the general idea we are going for

Co-authored-by: Jason Miller <[email protected]>
Co-authored-by: Marvin Hagemeister <[email protected]>

Unmount before inserting means we can use _prev == null to detect internals that need to be unmounted and removes unmounted nodes from the internal children linked list when doing inserts (so all _prev and _next pointers point to internals that will be included)

Use `.data` to detect if a component has been mounted or not.

Fix up next pointers when mounting or moving internals

Co-authored-by: Jason Miller <[email protected]>

- Comment out and skip tests we want to currently ignore
- Just focus on number of ops for reverse list atm

Here I'm using a variant of the longest increasing subsequence algorithm to determine which nodes to move. There are two key differences in my algorithm:

1. I am looping over the nodes in reverse order, so my algorithm is actually a longest decreasing subsequence (LDS) instead of longest increasing subsequence (LIS).

2. I don't use a binary search to insert new nodes into the "wip" LDS array.

…rying to read it

When we are rendering after a hydration that suspended, we need to detect the node that suspended while hydrating and send through the mount code path so it can resume hydration if on this rerender it can resume. Doing this also ensures the suspended hydration flags and state are preserved so additional rerenders have the same behavior.

Instead, check the length of the wipLDS array in the loop body. This change allows us to use the LDS loop to detect portals at the start of the child internal list

…atched vs unmatched internals

… recursion

I focused on the keys, render, fragments, and placholder tests for this commit

See test "should support moving Fragments between beginning and end" for an example failure this change fixes

See test "should insert a portal before new siblings when changing container to match siblings"

* Remove usages of MODE_UNMOUNTING & MATCHED_INTERNAL
* Clean up and improve comments

... since we are reusing it for different purposes in the diff algorithm

To fix this I had to teach getDomSibling to skip over nodes marked for insertion, as well as properly handle nodes with no children. See the fragment test "should preserve state when it does not change positions" for a test case that was fixed.

Note: This breaks a Portal test when changing a portal from having a different parent to the same parent. Probably need to detect that and set the moved flag to true. Maybe we could detect it in findMatches and set the move flag as well as a PORTAL flag on the internal to speed up similar checks

Speeds up benchmark perf on many_updates

Reduces recursion level by 1 function

I think this saves bytes cuz the implementation is another "loop over internals" and putting it into its own function gives the core internal variable the same minified name as other functions that also loop over internals.

Lots of tests changed cuz we unmount before doing insertions now

…DOM nodes

Fixes the portal test "should insert a portal before new siblings when changing container to match siblings"

…tDom-2-benchmark