Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ComponentChild types #4432

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+3 −2
Open

Update ComponentChild types #4432

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57bd5d0
Update ComponentChild types
sant123 Jul 6, 2024
2d439ac
- added Function type in ComponentChild
sant123 Jul 6, 2024
6d453a8
- changed Iterable to Array
sant123 Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,14 @@ export type Ref<T> = RefObject<T> | RefCallback<T> | null;

export type ComponentChild =
| VNode<any>
| object
| string
| number
| Array<ComponentChild>
| bigint
| boolean
| null
| undefined;
| undefined
| Function;
export type ComponentChildren = ComponentChild[] | ComponentChild;
Comment on lines 44 to 54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, do we really need to alter the type here? I do generally prefer ComponentChild being singular, with ComponentChildren being used if an array of children is needed.

If it's a compat issue, we can simply alter the ReactNode type instead?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks kinda weird - with this change, ComponentChild and ComponentChildren are the same type...


export interface Attributes {
Expand Down