Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions handling (null handling) #3034

Closed
amanpatniajmer opened this issue Mar 6, 2024 · 4 comments
Closed

Exceptions handling (null handling) #3034

amanpatniajmer opened this issue Mar 6, 2024 · 4 comments
Assignees
@Net-burst
Labels
bug Something isn't working

Comments

@amanpatniajmer
Copy link
Contributor

amanpatniajmer commented Mar 6, 2024 •
edited
Loading

There were no null checks on some of the fields, due to which we are seeing high number of exceptions. Following are the issues found during profiling -
image

  1. SetUidGppService.toInt() - NumberFormatException
  2. PubmaticBidder.parsedKADFloor() - NumberFormatException
  3. Ccpa.isEnforced() - PrebidException

Attaching PR to fix handle these exceptions -
#3035
@amanpatniajmer amanpatniajmer mentioned this issue Mar 7, 2024
Merged
@amanpatniajmer
Copy link
Contributor Author

@Net-burst any update on this?

@bretg bretg added the bug Something isn't working label Mar 22, 2024
@Net-burst
Copy link
Collaborator

@amanpatniajmer hi. Sorry for the delay. This is still on our plate. We should be able to get to the issue pretty soon.

@amanpatniajmer
Copy link
Contributor Author

@Net-burst got merged.

@Net-burst
Copy link
Collaborator

Yeah, thanks for your contribution @amanpatniajmer ! Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Net-burst Net-burst

Labels
bug Something isn't working
Projects
Prebid Server Prioritization
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Net-burst @bretg @amanpatniajmer