Sharethrough: Split multiformat bid request into 1 bid request per media type #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-dupuis
changed the title
|
The functional tests fail for this PR but also for other PR's. So I think this one doesn't cause the problem |
|
@maxime-dupuis Could you pls merge master to this PR, it should fix tests |
@SerhiiNahornyi Thanks I merged it. I don't seem to be able to rerun the tests though, can you do it? |
SerhiiNahornyi
requested changes
Jul 19, 2023
CTMBNara
requested changes
Jul 19, 2023
src/main/java/org/prebid/server/bidder/sharethrough/SharethroughBidder.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/bidder/sharethrough/SharethroughBidderTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring this pull request in the Golang adapter
Adresses: #2481