Tests: Increase test coverage for cookie_sync
#2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
added
tests
osulzhenko
requested changes
Sep 7, 2023
src/test/groovy/org/prebid/server/functional/service/PrebidServerService.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Show resolved
Hide resolved
osulzhenko
previously approved these changes
Sep 7, 2023
Net-burst
requested changes
Oct 23, 2023
| @@ -5,7 +5,7 @@ import net.minidev.json.annotate.JsonIgnore | |||
|
|
|||
| enum BidderName { | |||
|
|
|||
| ALIAS, GENERIC, RUBICON, APPNEXUS, BOGUS, OPENX | |||
| ALIAS, GENERIC, RUBICON, APPNEXUS, BOGUS, OPENX, ACEEX, ACUITYADS, GRID, AAX, ADKERNEL, MEDIANET | |||
There was a problem hiding this comment.
Please rearrange the list and put BOGUS somewhere at the beginning.
| @@ -43,9 +41,9 @@ class VendorListResponse { | |||
| Boolean usesNonCookieAccess | |||
| Boolean deviceStorageDisclosureUrl | |||
|
|
|||
| static Vendor getDefaultVendor() { | |||
| static Vendor getDefaultVendor(Integer id) { | |||
There was a problem hiding this comment.
id can be null? If not, please use int to signify this.
|
|
||
| List<BidderName> bidders | ||
| // Here we use wildcard for different compatibility |
There was a problem hiding this comment.
I don't understand what you meant by this comment.
| @@ -141,6 +141,14 @@ class PrebidServerService implements ObjectMapperWrapper { | |||
| response.as(CookieSyncResponse) | |||
| } | |||
|
|
|||
| @Step("[POST] /cookie_sync with uids cookie") | |||
| CookieSyncResponse sendCookieSyncRequest(CookieSyncRequest request, String uidsCookie) { | |||
There was a problem hiding this comment.
What was the point of duplicating the method, but using a String instead of POJO?
|
|
||
| def cookies = [:] | ||
| Map<String, String> header = null, | ||
| String uidsAudit = null) { |
There was a problem hiding this comment.
This shouldn't be here at all.
…rage-for-cookie-sync-endpoint # Conflicts: # src/test/groovy/org/prebid/server/functional/model/bidder/BidderName.groovy
…rage-for-cookie-sync-endpoint
osulzhenko
requested changes
Dec 11, 2023
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
requested changes
Dec 14, 2023
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
requested changes
Dec 15, 2023
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
src/test/groovy/org/prebid/server/functional/tests/CookieSyncSpec.groovy
Outdated
Show resolved
Hide resolved
SerhiiNahornyi
deleted the
increase-tests-coverage-for-cookie-sync-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.