Add DOOH Support #2580
Merged
Add DOOH Support #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to the prebid/prebid-server#2532 |
SerhiiNahornyi
requested changes
Sep 13, 2023
| } | ||
|
|
||
| return bidRequest.toBuilder() | ||
| // User was already prepared above | ||
| .user(bidderPrivacyResult.getUser()) | ||
| .device(bidderPrivacyResult.getDevice()) | ||
| .imp(prepareImps(bidder, imps, bidRequest, useFirstPartyData, context.getAccount())) | ||
| .app(preparedApp) | ||
| .site(preparedApp == null ? preparedSite : null) | ||
| .app(preparedApp).dooh(preparedDooh).site(preparedSite) |
There was a problem hiding this comment.
Each field should be on new line
There was a problem hiding this comment.
oh, the class will have more than 2000 lines of codes and checkstyle will fail, should we make the threshold lower?
src/main/java/org/prebid/server/auction/mediatypeprocessor/BidderMediaTypeProcessor.java
Outdated
Show resolved
Hide resolved
| return bidRequest.getApp() != null ? MetricName.openrtb2app : MetricName.openrtb2web; | ||
| if (bidRequest.getApp() != null) { | ||
| return MetricName.openrtb2app; | ||
| } else if (bidRequest.getDooh() != null) { |
There was a problem hiding this comment.
Super small but we expect to have 99.99% requests of site and app types
So please make if(site) before if(dooh)
Also I think it would be great if we will throw some exception by default, and have explicit checks for each mediaType before this default statement
There was a problem hiding this comment.
imho an exception here gonna be duplicate the request validator logic
src/main/java/org/prebid/server/proto/openrtb/ext/request/ExtDooh.java
Outdated
Show resolved
Hide resolved
AntoxaAntoxic
force-pushed
the
add-dooh-support
branch
from
cc1468c
to
b5d57ff
Compare
osulzhenko
force-pushed
the
add-dooh-support
branch
from
6f89744
to
b5d57ff
Compare
CTMBNara
requested changes
Oct 3, 2023
src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/deals/targeting/RequestContext.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/validation/RequestValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/validation/RequestValidator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/Generic26BidderConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/util/BidderDepsAssembler.java
Outdated
Show resolved
Hide resolved
CTMBNara
requested changes
Oct 4, 2023
src/main/java/org/prebid/server/privacy/gdpr/TcfDefinerService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/util/BidderDepsAssembler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/prebid/server/spring/config/bidder/util/BidderDepsAssembler.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/ExchangeServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/mediatypeprocessor/BidderMediaTypeProcessorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/prebid/server/auction/requestfactory/Ortb2ImplicitParametersResolverTest.java
Outdated
Show resolved
Hide resolved
CTMBNara
previously approved these changes
Oct 4, 2023
AntoxaAntoxic
force-pushed
the
add-dooh-support
branch
from
bbe9025
to
f1b5d11
Compare
And1sS
previously approved these changes
Oct 11, 2023
AntoxaAntoxic
force-pushed
the
add-dooh-support
branch
from
2b153c1
to
caec98f
Compare
SerhiiNahornyi
requested changes
Oct 26, 2023
# Conflicts: # src/main/java/org/prebid/server/auction/ExchangeService.java
SerhiiNahornyi
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.