Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Huawei Bidder #2609

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Add Huawei Bidder #2609

merged 8 commits into from
Nov 7, 2023

Conversation

AntoxaAntoxic
Copy link
Collaborator

No description provided.

@AntoxaAntoxic AntoxaAntoxic self-assigned this Sep 5, 2023
This was linked to issues Sep 5, 2023
Port huaweiads adapter #2169
Closed
Port PR from PBS-Go: Update HuaweiAds email #2607
Closed
@AntoxaAntoxic AntoxaAntoxic force-pushed the add-huawei-bidder branch 4 times, most recently from b296655 to 12f62c8 Compare September 6, 2023 08:09
And1sS
And1sS requested changes Sep 6, 2023
View reviewed changes
src/main/java/com/iab/openrtb/response/DataObject.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/CountryCodeResolver.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/CountryCodeResolver.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/AdsType.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/request/AdSlot30.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/response/CreativeType.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/response/CreativeType.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/response/PictureAdm.java Show resolved Hide resolved
CTMBNara
CTMBNara requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 1

src/main/java/org/prebid/server/bidder/huaweiads/ClientTimeFormatter.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/ClientTimeFormatter.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/CountryCodeResolver.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/CountryCodeResolver.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdSlotBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdSlotBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdSlotBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdSlotBuilder.java Outdated Show resolved Hide resolved
CTMBNara
CTMBNara requested changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2

src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdmBuilder.java Outdated Show resolved Hide resolved
CTMBNara
CTMBNara requested changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 3

src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdsBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/HuaweiAdsBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/huaweiads/model/response/AdmUtils.java Outdated Show resolved Hide resolved
@AntoxaAntoxic AntoxaAntoxic force-pushed the add-huawei-bidder branch 3 times, most recently from a856b7a to 7632614 Compare September 21, 2023 12:24
CTMBNara
CTMBNara previously approved these changes Oct 20, 2023
View reviewed changes
SerhiiNahornyi
SerhiiNahornyi requested changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make more meaningful names for IT tests

@SerhiiNahornyi SerhiiNahornyi merged commit d2dc5fd into master Nov 7, 2023
2 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the add-huawei-bidder branch November 7, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg left review comments

@And1sS And1sS And1sS approved these changes

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

@CTMBNara CTMBNara CTMBNara left review comments

Assignees

@AntoxaAntoxic AntoxaAntoxic

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Update HuaweiAds email Port huaweiads adapter
5 participants
@AntoxaAntoxic @bretg @And1sS @CTMBNara @SerhiiNahornyi