Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent ExchangeService from emptying Source object #2849

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: prevent ExchangeService from emptying Source object #2849

merged 2 commits into from
Jan 5, 2024

Conversation

vpontesfreestar
Copy link
Contributor

@vpontesfreestar vpontesfreestar commented Dec 18, 2023 •
edited
Loading

This PR aims to Prevent ExchangeService from emptying the Source object when TRANSMIT_TID is false. This PR #2686 added the TRANSMIT_TID action. In the method prepareSource, when the bidderSchain is null, the method returns a Source object with null schains. So, the fix updates the method to return the receivedSource with a null tid property and keep the received schains.

@SerhiiNahornyi SerhiiNahornyi merged commit 152dd12 into prebid:master Jan 5, 2024
2 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoxaAntoxic AntoxaAntoxic AntoxaAntoxic approved these changes

@armando-fs armando-fs armando-fs approved these changes

@SerhiiNahornyi SerhiiNahornyi Awaiting requested review from SerhiiNahornyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vpontesfreestar @AntoxaAntoxic @armando-fs @SerhiiNahornyi