MType Support for the Adxcg Bidder #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
requested changes
Jan 10, 2024
| final BidType bidType = getBidType(bid, bidRequest.getImp()); | ||
| return BidderBid.of(bid, bidType, bidResponse.getCur()); | ||
| final BidType bidType = getBidMediaType(bid); | ||
| return BidderBid.of(bid, bidType, currency); |
There was a problem hiding this comment.
return BidderBid.of(bid, bidType, currency); this can be outside try/catch block
There was a problem hiding this comment.
imho it doesn't make much sense moving it outside since we return a bid or null depending on the bid type, so it will require additional if-statement and so on... not a big deal, if you still think it's better to do, let me know
There was a problem hiding this comment.
Try/catch adds mutch logic under the hood, for performance reasons it is much better to use plain if
But for this case, we can go with existing solution
src/test/java/org/prebid/server/bidder/adxcg/AdxcgBidderTest.java
Outdated
Show resolved
Hide resolved
SerhiiNahornyi
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.