Flipp: Handle privacy for the user key #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
changed the title
CTMBNara
requested changes
Jan 19, 2024
There was a problem hiding this comment.
A few important changes that need to be made since the logic of this adapter is different from the logic of the corresponding adapter in GO:
bid.{id, crid}. currently null -> "null", but need to be null -> "0"bid.h. currently ifinline.consents not empty, but need to beinline.consents[0].data != nullCampaignRequestBody.keywords. We need to extract it from the Site, not from the User.TCString.decodehas a huge performance impact, don't parse theconsentunless necessary.- check for Purpose 4, not for Purpose 3.
Also please change the order of the methods so that they are in the order they are called.
CTMBNara
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.