Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NextMillennium: Add extraInfo support and update yaml #2910

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Jan 17, 2024

As well update yaml file corresponding to this PR

@marki1an marki1an self-assigned this Jan 17, 2024
@marki1an marki1an linked an issue Jan 17, 2024 that may be closed by this pull request
@marki1an marki1an changed the title NextMillennium: add extraInfo support and update yaml NextMillennium: Add extraInfo support and update yaml Jan 17, 2024
@marki1an marki1an added the do not merge Not the time for merging yet label Jan 18, 2024
Copy link
Collaborator

@CTMBNara CTMBNara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please, remove .filter(Objects::nonNull) on line 70. This is redundant.

@SerhiiNahornyi SerhiiNahornyi merged commit 74947e0 into master Jan 29, 2024
2 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the update-nextMillenniumBidder branch January 29, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Nextmillennium: add extra_info support
4 participants