Test: Sec-Browsing-Topic header
#2992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
requested changes
Feb 19, 2024
Comment on lines
281
to
282
| assert bidderRequest.user.data.segment.collectMany { it -> it.id } | ||
| .containsAll([secBrowsingTopic.segments[0]].sort()) |
There was a problem hiding this comment.
Can be simplified:
bidderRequest.user.data[0].segment.id == secBrowsingTopic.segments
Comment on lines
216
to
217
| def oneSecBrowsingTopic = SecBrowsingTopic.defaultSetBrowsingTopic(1, [PBSUtils.randomNumber as String], randomSegClass) | ||
| def secondSecBrowsingTopic = SecBrowsingTopic.defaultSetBrowsingTopic(1, [PBSUtils.randomNumber as String], randomSegClass) |
There was a problem hiding this comment.
first instead of one, but why are you using it in some cases one, two and in this one, first, second?
| def "PBS should populate user.data with empty name when privacy sand box present with empty name"() { | ||
| given: "PBS with empty auction privacy sand box" | ||
| def prebidServerServiceWithTopicsDomain | ||
| = pbsServiceFactory.getService(["auction.privacysandbox.topicsdomain": ""]) |
There was a problem hiding this comment.
what about case when "auction.privacysandbox.topicsdomain": null?
…o update-functional-tests-for-sec-browsing-topics-support
…o update-functional-tests-for-sec-browsing-topics-support
osulzhenko
approved these changes
Feb 20, 2024
SerhiiNahornyi
deleted the
update-functional-tests-for-sec-browsing-topics-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.