New Adapter: Trustedstack #3111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
requested changes
Apr 19, 2024
Comment on lines
121
to
125
| final Bid bid1 = Bid.builder().impid("imp_id").mtype(1).build(); | ||
| final Bid bid2 = Bid.builder().impid("imp_id").mtype(2).build(); | ||
| final Bid bid3 = Bid.builder().impid("imp_id").mtype(3).build(); | ||
| final Bid bid4 = Bid.builder().impid("imp_id").mtype(4).build(); | ||
| bids.add(bid1); |
There was a problem hiding this comment.
We would prefer to have separate test for each mtype
There was a problem hiding this comment.
@SerhiiNahornyi requesting review as the requested changes has been implemented.
Comment on lines
45
to
47
| private String resolveEndpoint(String configEndpoint, String externalUrl) { | ||
| return configEndpoint.replace(EXTERNAL_URL_MACRO, HttpUtil.encodeUrl(externalUrl)); | ||
| } |
There was a problem hiding this comment.
URL resolving is usually a part of Bidder code, so please move it there
AntoxaAntoxic
approved these changes
May 9, 2024
|
@SerhiiNahornyi requesting to share your approval if all looks good |
SerhiiNahornyi
approved these changes
May 22, 2024
SerhiiNahornyi
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trustedstack server adapter added.