Functional tests for bid.exp in response #3222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested changes
Jun 3, 2024
| } | ||
|
|
||
| def "PBS auction should resolve exp from request.ext.prebid.cache.vastxml when it have value"() { | ||
| given: "Default basic bid with ext.prebid.cache.bids" |
| } | ||
|
|
||
| def "PBS auction should resolve exp from request.imp[].exp when it have value"() { | ||
| given: "Default basic bid with exp" |
| 'cache.video-ttl-seconds' : hostVideoTtl as String]) | ||
|
|
||
| def "PBS auction should resolve bid.exp from response that is set by the bidder’s adapter"() { | ||
| given: "Default basic bid with exp" |
| assert response.seatbid.bid.first.exp == [hostBannerTtl] | ||
| } | ||
|
|
||
| def "PBS auction should resolve exp from global video config for banner request"() { |
osulzhenko
force-pushed
the
functional-tests/populate-bid-exp
branch
from
e05a48e
to
bec8214
Compare
marki1an
requested changes
Jun 12, 2024
Comment on lines
76
to
78
| and: "Set bidder response without exp" | ||
| def bidResponse = BidResponse.getDefaultBidResponse(bidRequest) | ||
| bidder.setResponse(bidRequest.id, bidResponse) |
There was a problem hiding this comment.
It would be great to see explicitly without exp, since in the future somebody can change the default bid response and add exp field. by default
| assert response.seatbid.bid.first.exp == [bidRequestExp] | ||
| } | ||
|
|
||
| def "PBS auction should resolve exp from request.ext.prebid.cache for request when it have invalid type"() { |
There was a problem hiding this comment.
Maybe shouldn't resolve exp?
marki1an
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.