Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Add pull request checklist #3227

Merged
merged 2 commits into from
Jun 4, 2024
Merged

GitHub: Add pull request checklist #3227

merged 2 commits into from
Jun 4, 2024

Conversation

And1sS
Copy link
Member

@And1sS And1sS commented Jun 4, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

Pull request reviews are time consuming.

🧠 Rationale behind the change

We would like to ease pull request review process, thus we decided to introduce pull request checklist.

🧪 Test plan

No test plan needed.

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@And1sS And1sS changed the title add-pr-checklist GitHub: Add pull request checklist Jun 4, 2024
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SerhiiNahornyi SerhiiNahornyi merged commit e7ba1a7 into master Jun 4, 2024
2 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the add-pr-checklist branch June 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants