Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ix: Update bidder #3299

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Ix: Update bidder #3299

merged 4 commits into from
Jul 16, 2024

Conversation

CTMBNara
Copy link
Collaborator

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

And1sS
And1sS previously approved these changes Jul 11, 2024
@CTMBNara CTMBNara added the do not merge Not the time for merging yet label Jul 11, 2024
@CTMBNara CTMBNara requested a review from And1sS July 11, 2024 14:56
@CTMBNara CTMBNara removed the do not merge Not the time for merging yet label Jul 11, 2024
@CTMBNara CTMBNara changed the title Ix: Refactor Ix: Update bidder Jul 11, 2024
@SerhiiNahornyi SerhiiNahornyi merged commit 76f856f into master Jul 16, 2024
5 checks passed
@SerhiiNahornyi SerhiiNahornyi deleted the ix/update-bidder branch July 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: IX: save/restore global var in test
4 participants