Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gumgum remove video validations #3357

Merged

Conversation

gg-natalia
Copy link
Contributor

@gg-natalia gg-natalia commented Aug 6, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?
Currently, Prebid Server conducts validations for certain video parameters before passing inventory requests to the GG ad server. This preliminary validation prevents the GG ad server from receiving complete inventory data, limiting our ability to apply comprehensive validations and record inventory details.

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

Since this is about removing validations should bot present any risk

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@gg-natalia gg-natalia changed the title ADTS-455 remove video validations Gumgum remove video validations Aug 6, 2024
@SerhiiNahornyi SerhiiNahornyi merged commit 190ae6e into prebid:master Aug 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants