Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage of functional tests for ortb2 blocking module #3415

Conversation

osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Aug 30, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added do not merge Not the time for merging yet work in progress Signals not finished work tests Functional or other tests labels Aug 30, 2024
@osulzhenko osulzhenko self-assigned this Aug 30, 2024
@osulzhenko osulzhenko marked this pull request as ready for review August 31, 2024 10:36
@osulzhenko osulzhenko removed do not merge Not the time for merging yet work in progress Signals not finished work labels Aug 31, 2024
@osulzhenko osulzhenko changed the title WIP: Increase coverage of functional tests for ortb2 blocking module Increase coverage of functional tests for ortb2 blocking module Aug 31, 2024
@osulzhenko osulzhenko force-pushed the functional-tests-for-ortb2-blocking-module branch from 303dc63 to 2c8b35e Compare August 31, 2024 10:42
@osulzhenko osulzhenko changed the base branch from master to ortb-blocking/aliases-bug-fix September 18, 2024 17:58
@SerhiiNahornyi SerhiiNahornyi merged commit 9ad92e2 into ortb-blocking/aliases-bug-fix Sep 19, 2024
@SerhiiNahornyi SerhiiNahornyi deleted the functional-tests-for-ortb2-blocking-module branch September 19, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants