-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented audienceNetwork (facebook) bidder for ortb endpoint #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
.map(SeatBid::getBid) | ||
.filter(Objects::nonNull) | ||
.flatMap(Collection::stream) | ||
.limit(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Limit is not applicable for OpenRTB. Should be removed.
.build(); | ||
} | ||
|
||
private Imp makeImp(Imp imp, String pubId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Input arg pubId
should be named like placementId
.
} | ||
|
||
@Override | ||
public Map<String, String> extractTargeting(ObjectNode ext) { | ||
return Collections.emptyMap(); | ||
} | ||
|
||
private ExtImpFacebook parseExtImpFacebook(Imp imp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rearrange all methods in call order, but not by public/private/etc for better reading.
|
||
public class FacebookBidderTest extends VertxTest { | ||
|
||
private static final String ENDPOINT_URL = "https://sovrn.com/openrtb2d"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix sovrn
url pls.
.flatExtracting(BidRequest::getImp) | ||
.isEmpty(); | ||
assertThat(result.getErrors()).hasSize(1) | ||
.element(0).extracting(BidderError::getMessage) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.element(0)
call can be skipped. Check all bellow cases for this pls.
return null; | ||
} | ||
|
||
final int h = banner.getH(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we sure in non-null values?
return placementIdSplit[0]; | ||
} | ||
|
||
private Site makeSite(BidRequest bidRequest, String pubId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method can be static
. See all other pls.
* Added support reading country from RSID cookie for GDPR * Added support reading country from RSID cookie for GDPR - fix PR * Added support reading country from RSID cookie for GDPR - fix PR * Added support reading country from RSID cookie for GDPR - add gdpr.rubicon.rsid-cookie-encryption-key property to docs * Merge branch 'master-rubicon' into gdpr-read-country-from-rsid-cookie # Conflicts: # docs/config-app.md # src/main/java/org/prebid/server/gdpr/GdprService.java # src/main/java/org/prebid/server/handler/SetuidHandler.java # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java # src/rpm/application.yaml # src/test/java/org/prebid/server/gdpr/GdprServiceTest.java # src/test/resources/org/prebid/server/ApplicationTest/test-application.properties
No description provided.