Implemented bid price adjustment #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanchyk
suggested changes
Apr 6, 2018
| return bidderCatalog.bidderRequesterByName(resolveBidder(bidder, aliases)) | ||
| .requestBids(bidderRequest.getBidRequest(), timeout) | ||
| .map(this::validateAndUpdateResponse) | ||
| .map(seat -> ExchangeService.applyBidPriceAdjustment(seat, bidPriceAdjustmentFactor)) |
There was a problem hiding this comment.
No need for full qualifier
.map(seat -> applyBidPriceAdjustment(seat, bidPriceAdjustmentFactor))
|
|
||
| validateAliases(aliases); | ||
| final boolean isPrebidExtPresent = extRequestPrebid != null; |
There was a problem hiding this comment.
Do we need separate var for one time using?
|
|
||
| for (Map.Entry<String, BigDecimal> bidderAdjustment : adjustmentFactors.entrySet()) { | ||
| final String bidder = bidderAdjustment.getKey(); | ||
| final BigDecimal adjustmentFactor = bidderAdjustment.getValue(); |
There was a problem hiding this comment.
Minor. We can move down adjustmentFactor before if(...) statement.
| } | ||
|
|
||
| @Test | ||
| public void shouldRequestBidsWithBidAdjustmentFactor() { |
There was a problem hiding this comment.
Duplicates shouldReturnBidsWithAdjustedPricesWhenAdjustmentFactorPresent test.
| final ValidationResult result = requestValidator.validate(bidRequest); | ||
|
|
||
| // then | ||
| assertThat(result.getErrors()).hasSize(0); |
There was a problem hiding this comment.
hasSize(0) can be replaced with isEmpty(). Check another places pls.
rpanchyk
approved these changes
Apr 6, 2018
|
@jordillachmrf also took a look at these changes and is ok with them. |
jordillachmrf
referenced
this pull request
in Marfeel/prebid-server-java
Apr 15, 2018
schernysh
pushed a commit
that referenced
this pull request
Nov 25, 2019
ishihanvcs
pushed a commit
to ishihanvcs/prebid-server-java
that referenced
this pull request
Apr 10, 2023
Docker support & version logging
VeryExtraordinaryUsername
added a commit
that referenced
this pull request
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.