-
Notifications
You must be signed in to change notification settings - Fork 732
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
semgrep rule to detect undesirable package imports in adapter code (#…
- Loading branch information
1 parent
a39f5ca
commit 613db40
Showing
2 changed files
with
60 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| import ( | ||
| // ok: package-import-check | ||
| "fmt" | ||
| // ok: package-import-check | ||
| "os" | ||
| // ruleid: package-import-check | ||
| "github.com/mitchellh/copystructure" | ||
| // ruleid: package-import-check | ||
| "github.com/golang/glog" | ||
| ) | ||
|
|
||
| import ( | ||
| // ok: package-import-check | ||
| "fmt" | ||
| // ruleid: package-import-check | ||
| cs "github.com/mitchellh/copystructure" | ||
| // ok: package-import-check | ||
| "os" | ||
| // ruleid: package-import-check | ||
| log "github.com/golang/glog" | ||
| ) | ||
|
|
||
| import ( | ||
| // ok: package-import-check | ||
| "fmt" | ||
| // ruleid: package-import-check | ||
| cs "github.com/mitchellh/copystructure/subpackage" | ||
| // ok: package-import-check | ||
| "os" | ||
| // ruleid: package-import-check | ||
| log "github.com/golang/glog/subpackage" | ||
| ) | ||
|
|
||
| // ruleid: package-import-check | ||
| import "github.com/golang/glog" | ||
|
|
||
| // ruleid: package-import-check | ||
| import "github.com/mitchellh/copystructure" | ||
|
|
||
| // ruleid: package-import-check | ||
| import log "github.com/golang/glog" | ||
|
|
||
| // ruleid: package-import-check | ||
| import copy "github.com/mitchellh/copystructure" | ||
|
|
||
| // ok: package-import-check | ||
| import "fmt" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| rules: | ||
| - id: package-import-check | ||
| message: Importing "$PKG" package is not recommended in adapter code | ||
| languages: | ||
| - go | ||
| severity: ERROR | ||
| pattern-either: | ||
| - patterns: | ||
| - pattern: import "$PKG" | ||
| - focus-metavariable: $PKG | ||
| - metavariable-regex: | ||
| metavariable: $PKG | ||
| regex: (^github\.com/mitchellh/copystructure(/.*)?$|^github\.com/golang/glog(/.*)?$) |