Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional DSA validations #3438

Closed
patmmccann opened this issue Jan 31, 2024 · 8 comments
Closed

Additional DSA validations #3438

patmmccann opened this issue Jan 31, 2024 · 8 comments
Labels

Comments

@patmmccann
Copy link

patmmccann commented Jan 31, 2024

Here are some we're looking at in JS when DSA is required:

  1. If regs.ext.dsa.pubrender exists and is 2, response adrender should not = 1
  2. If regs.ext.dsa.pubrender exists and is 0, response adrender must = 1
  3. regs.ext.dsa.pubrender does not exist, don't do these validations

Also, there are field length validations not defined with the original passthrough requirements. The paid and behalf response fields should have not more than 100 chars or the response should be rejected.

In any case:

  • add an entry in ext.prebid.warning when in debug mode
  • use seat nonbid code 305 as the reject reason (305 "Response Rejected - Privacy")
@bretg
Copy link
Contributor

bretg commented Feb 5, 2024

I think we need to define new seat non-bid codes.

@bretg
Copy link
Contributor

bretg commented Feb 9, 2024

This would be the first instance doing a legal basis check on the bid response. The Go and Java teams will have to look into the impact.

@bretg
Copy link
Contributor

bretg commented Feb 13, 2024

Opened PR for the IAB seatnonbid code file to propose code 305 to cover rejecting responses for privacy reasons. InteractiveAdvertisingBureau/openrtb#163

@bretg
Copy link
Contributor

bretg commented Feb 15, 2024

As discussed in committee yesterday, pulled the legal basis check out into a separate issue #3508 and made the remaining items here ready-for-dev

@bsardo
Copy link
Collaborator

bsardo commented Feb 20, 2024

Opened PR for the IAB seatnonbid code file to propose code 305 to cover rejecting responses for privacy reasons. InteractiveAdvertisingBureau/openrtb#163

@bretg just to clarify, I assume we will use 305 if any of the DSA validation checks fail including if the DSA object is required but not present on the bid, is that correct?
I only ask because we previously chose 300 for the required validation check and I also see mention above of possibly proposing two other new codes, 310 and 311, be created.

@bretg
Copy link
Contributor

bretg commented Feb 20, 2024

@bsardo - we settled on 305 in the PMC last week. Removed references to the others

@SyntaxNode
Copy link
Contributor

Implemented in PBS-Go v2.9.0. We're using seat non-bid code 300 for now and will change it to 305 when that's accepted by the IAB.

@bretg
Copy link
Contributor

bretg commented Jun 10, 2024

released with PBS-Java 3.2

@bretg bretg closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants