Remove Restrictions for UUID Generation For Stored Bid Requests #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Mar 28, 2022
endpoints/openrtb2/auction_test.go
Outdated
| @@ -1879,7 +1879,7 @@ func TestStoredRequestGenerateUuid(t *testing.T) { | |||
| expectedID: "ThisID", | |||
| }, | |||
| { | |||
| description: "GenerateRequestID is true, but rawData is a site request, we should not generate uuid", | |||
| description: "GenerateRequestID is true, and rawData is a site request, we should generate uuid", | |||
There was a problem hiding this comment.
If we should generate a uuid, then shouldn't expectedID be uuid?
SyntaxNode
reviewed
Mar 28, 2022
endpoints/openrtb2/auction.go
Outdated
| return nil, nil, []error{err} | ||
| } | ||
| if isAppRequest && (deps.cfg.GenerateRequestID || bidRequestID == "{{UUID}}") { | ||
| if deps.cfg.GenerateRequestID || bidRequestID == "{{UUID}}" { |
There was a problem hiding this comment.
The original feature request changed a few times, but I believe we decided to generate a new bid request id for app and amp auctions. I'm good with expanding this to any request type if the special {{UUID}} token is used in the stored request, but the deps.cfg.GenerateRequestID should still be scoped to app and amp requests, IMHO.
ie: something more akin to
(deps.cfg.GenerateRequestID && (isApp || isAmp)) || bidRequestID == "{{UUID}}"
There was a problem hiding this comment.
👍 This has been addressed. The amp endpoint handles the amp case by generating a request ID if deps.cfg.GenerateRequestID is set.
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow to two previous PRs #1938 and #2000
In those PRs, the goal was to generate a UUID for when an app or amp request had a stored bid request and that stored bid request had an ID = {{UUID}} or a config flag
GenerateRequestIdwas set to true.This update removes the restriction where the auction endpoint would check if the request was an app request, and instead, as long as the request has a stored request, and the macro {{UUID}} or the config flag is set to true, the UUID would be generated.