New Adapter: OwnAdX

[ownAdx-prebid]

No description provided.

[ownAdx-prebid]

@onkarvhanumante one of adapter have same endpoint http://{{.Host}}-prebid.smart-hub.io/?seat={{.AccountID}}&token={{.SourceId}}

[ownAdx-prebid]

Thank You for update We respond mail with received .

[ownAdx-prebid]

Can you review the updated changes and let me know need any more changes

[ownAdx-prebid]

Hello Prebid Team, can you please update us why we stuck here,if any changes will required so please let me know. Thank you

[onkarvhanumante]

Hello Prebid Team, can you please update us why we stuck here,if any changes will required so please let me know. Thank you

@ownAdx-prebid, we are following up this url related change http://{{.Host}}-prebid.owadx.com/bidder/bid/{{.AccountID}}/000?token={{.SourceId}}

[Sonali-More-Xandr]

@ownAdx-prebid Please add dev-docs here

[ownAdx-prebid]

@ownAdx-prebid Please add dev-docs here

We are submitting the OwnadX documentation with PR id #4687

[bretg]

docs PR prebid/prebid.github.io#4687

[onkarvhanumante]

prebid/prebid.github.io#4687

@ownAdx-prebid thanks for keeping patience with code reviews. Agree that few adapter today make use of dynamic subdomain. But this usage is being discouraged and prebid team in future will be working to avoid usage of dynamic subdomain in endpoint url.

Major concerns with such usage are,

• security concerns
  The security aspect is alleviated by using a fixed top level domain. Due to the potential harm to hosts, we are strict in this requirement. We are working towards fixing the few adapters currently in violation.
• connection performance
  The connection performance advice is for your benefit. Client specific subdomains prevent Prebid Server from reusing connections across your clients which results in more connections needed for your adapter. The issue gets worse the more successful you are in attracting new clients. Hosts may choose to disable your adapter due to this behavior.

Best practice is for your domain to be fixed and any parameters specified in the path or query.

[ownAdx-prebid]

prebid/prebid.github.io#4687

@ownAdx-prebid thanks for keeping patience with code reviews. Agree that few adapter today make use of dynamic subdomain. But this usage is being discouraged and prebid team in future will be working to avoid usage of dynamic subdomain in endpoint url.

Major concerns with such usage are,

• security concerns
  The security aspect is alleviated by using a fixed top level domain. Due to the potential harm to hosts, we are strict in this requirement. We are working towards fixing the few adapters currently in violation.
• connection performance
  The connection performance advice is for your benefit. Client specific subdomains prevent Prebid Server from reusing connections across your clients which results in more connections needed for your adapter. The issue gets worse the more successful you are in attracting new clients. Hosts may choose to disable your adapter due to this behavior.

Best practice is for your domain to be fixed and any parameters specified in the path or query.

Thank you for details.
We will make changes according to it and will back to you

[ownAdx-prebid]

Hello @onkarvhanumante
We are change dynamic host to static host. Let me know any more changes.

[onkarvhanumante]

@ownAdx-prebid added some suggestions

[onkarvhanumante]

@onkarvhanumante can you elaborate more about point should consider appending err if check on line 202 is true

prebid-server/adapters/ownadx/ownadx.go

Lines 101 to 102 in 3bf0199

	imps, impExts, err := getImpressionsAndImpExt(request.Imp)
	if len(imps) == 0 {

apologies, I meant to refer 102 line

[ownAdx-prebid]

Hello @onkarvhanumante
We make changes as you suggest .

[onkarvhanumante]

@ownAdx-prebid requesting to address opened comments

• #discussion_r1263550459

• #discussion_r1263502369

• #discussion_r1263495180

[ownAdx-prebid]

@onkarvhanumante can you elaborate more about point should consider appending err if check on line 202 is true

prebid-server/adapters/ownadx/ownadx.go

Lines 101 to 102 in 3bf0199

	imps, impExts, err := getImpressionsAndImpExt(request.Imp)
	if len(imps) == 0 {

apologies, I meant to refer 102 line

We make changes for it

[ownAdx-prebid]

#discussion_r1263495180
We make changes for it.

[onkarvhanumante]

@ownAdx-prebid ownAdx-prebid:NewAdapter/OwnAdX branch seems out of sync with prebid master. Resulting in failure of Adapter semgrep checks. Requesting sync your branch with master

[ownAdx-prebid]

Hello @onkarvhanumante
We sync with prebid master and done changes for #discussion_r1266640622

[onkarvhanumante]

@ownAdx-prebid requesting to address or provide views on

• r1263502369

• r1263550459

[ownAdx-prebid]

@onkarvhanumante

• r1263502369 Resolved
• r1263550459 Is this Mandatory ?

[onkarvhanumante]

@onkarvhanumante

• r1263502369 Resolved
• r1263550459 Is this Mandatory ?

r1263550459 is not Mandatory. But more recommended way with latest ortb specs