RTBHouse: native support #3212

piotrj-rtbh · 2023-10-13T11:22:44Z

Type of change

Feature
Code style update (formatting, local variables)
Bugfix

Description of change

Native ads are now available to be processed and accessed by RTB House adapter. Test coverage has increased significantly.

There is also a little bugfix added to how the adapter handles bid floors. Previous version dropped bid floor defined in a bidder param ("bidfloor") when publishers didn't set currency module. Now it is fine with that case and the bidfloor currency is set to the bidder's default (USD).

Other information

Please reach us at [email protected] with [email protected] and cc [email protected].

github-actions · 2023-10-13T11:23:43Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 18c794b

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:28:	Builder			100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:36:	MakeRequests		94.1%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:106:	getImpressionExt	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:128:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:193:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:204:	getNativeAdm		100.0%
total:									(statements)		97.7%

github-actions · 2023-10-13T12:03:37Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 4478925

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:28:	Builder			100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:36:	MakeRequests		94.1%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:106:	getImpressionExt	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:128:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:191:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:202:	getNativeAdm		100.0%
total:									(statements)		97.6%

onkarvhanumante · 2023-10-19T07:44:26Z

adapters/rtbhouse/rtbhouse.go

+ default:
+ return openrtb_ext.BidTypeBanner


should not default to banner type. Should return error if found an unknown bid type

@onkarvhanumante Many adapters behave like that by returning banner type as default and/or do not return an error: see aceex, acuityads,adhese just to name a few from the top and even pubmatic and pubnative.

Our bidder may sometimes skip the mtype if the response contains banner data. Such a situation indicates we have to suppose we've got banner data in response.

Our Java adapter works also like the above.

@piotrj-rtbh Thanks for the clarifiacation

If bidder skips setting mtype then can fallback to check if imp.Banner is not null and then return openrtb_ext.BidTypeBanner

Our bidder may sometimes skip the mtype if the response contains banner data

Also should add above as comment in adapter code

If bidder skips setting mtype then can fallback to check if imp.Banner is not null and then return openrtb_ext.BidTypeBanner

@onkarvhanumante I didn't get it well. Do you mean I need to loop through request's imp[] array, find matching element (by impid I suppose) and check it's Banner prop if it's null or not?

yes

If bidder skips setting mtype then can fallback to check if imp.Banner is not null and then return openrtb_ext.BidTypeBanner

@onkarvhanumante I didn't get it well. Do you mean I need to loop through request's imp[] array, find matching element (by impid I suppose) and check it's Banner prop if it's null or not?

yes for default case to check if banner was set in req.Imp[]. However this may not work if your adapter support multi-format imp

I think if you wanna default to Banner then you could use the following code to check the native first and then default to banner.

func getMediaTypeForBid(bid openrtb2.Bid) openrtb_ext.BidType { switch bid.MType { case openrtb2.MarkupNative: return openrtb_ext.BidTypeNative default: return openrtb_ext.BidTypeBanner }

The above should work for your adapter. But I strongly recommend that you should change your bidder to properly set MType and not skip that value.

Also mention in the docs that your adapter defaults to BidTypeBanner.

@onkarvhanumante @gargcreation1992

We decided to always return MType from the bidder. Just in case the bid type detecting function now may return an error if MType is not supported. Returned bids which have unknown MType are skipped then.

github-actions · 2023-10-20T09:49:05Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 3012d46

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:28:	Builder			100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:36:	MakeRequests		94.1%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:106:	getImpressionExt	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:128:	MakeBids		100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:194:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/adapters/rtbhouse/rtbhouse.go:205:	getNativeAdm		100.0%
total:									(statements)		97.7%

onkarvhanumante · 2023-10-26T16:02:23Z

@piotrj-rtbh , prebid server has published major release 2.0.

Requesting to sync with rtbh-lotani:rtbhouse/native-support with latest prebid server master.

github-actions · 2023-10-26T16:35:06Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 2cc2bd1

rtbhouse

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:28:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:36:	MakeRequests		94.1%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:106:	getImpressionExt	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:128:	MakeBids		100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:194:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v2/adapters/rtbhouse/rtbhouse.go:205:	getNativeAdm		100.0%
total:									(statements)		97.7%

piotrj-rtbh · 2023-10-26T16:42:35Z

Requesting to sync with rtbh-lotani:rtbhouse/native-support with latest prebid server master.

@onkarvhanumante Thank you. Fork synced.

This reverts commit 2540dd8.

piotrj-rtbh · 2023-11-02T12:46:26Z

@bsardo Could you please describe the reason why this PR commit has been reverted?
Native ads support for Java version has been added with this PR: prebid/prebid-server-java#2641 and the automatically created cross-repo issue has been resolved: #3223 where we promised to deliver native ads support for Go version.

This reverts commit 2540dd8.

bsardo · 2023-11-30T03:06:44Z

Hi @piotrj-rtbh, I apologize for the revert and the slow response. It was solely a matter of circumstance. We built v2.0.0 and then realized there was a problem with it so we put up a fix but our team merged this PR before the patch v2.0.1 was built. As a result, we reverted your PR with the intention of remerging it after the patch was built but forgot to do so.

RTBHouse: native support

18c794b

RTBHouse: unknown mtype defaults to banner (align with Java)

4478925

piotrj-rtbh marked this pull request as ready for review October 13, 2023 13:23

gargcreation1992 assigned gargcreation1992 and onkarvhanumante Oct 16, 2023

piotrj-rtbh mentioned this pull request Oct 16, 2023

Port PR from PBS-Java: RTBHouse: native ads support #3223

Closed

onkarvhanumante reviewed Oct 19, 2023

View reviewed changes

RTBHouse: detecting media type may return an error

3012d46

piotrj-rtbh requested review from gargcreation1992 and onkarvhanumante October 20, 2023 10:00

onkarvhanumante approved these changes Oct 23, 2023

View reviewed changes

onkarvhanumante assigned Sonali-More-Xandr Oct 26, 2023

Merge branch 'prebid:master' into rtbhouse/native-support

2cc2bd1

Sonali-More-Xandr approved these changes Oct 30, 2023

View reviewed changes

Sonali-More-Xandr merged commit 2540dd8 into prebid:master Oct 30, 2023
5 checks passed

cross-repo-issue-creation bot mentioned this pull request Oct 30, 2023

Port PR from PBS-Go: RTBHouse: native support prebid/prebid-server-java#2734

Closed

bsardo added a commit to bsardo/prebid-server that referenced this pull request Oct 30, 2023

Revert "RTBHouse: native support (prebid#3212)"

24ce6e2

This reverts commit 2540dd8.

bsardo added a commit that referenced this pull request Oct 30, 2023

Revert "RTBHouse: native support (#3212)" (#3271)

72463be

This reverts commit 2540dd8.

piotrj-rtbh mentioned this pull request Nov 14, 2023

Revert "RTBHouse: native support (#3212)" #3271

Merged

svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023

RTBHouse: native support (prebid#3212)

a72b2f3

svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023

Revert "RTBHouse: native support (prebid#3212)" (prebid#3271)

251e02d

This reverts commit 2540dd8.

piotrj-rtbh mentioned this pull request Nov 29, 2023

RTBHouse: native support (renewal) #3328

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RTBHouse: native support #3212

RTBHouse: native support #3212

piotrj-rtbh commented Oct 13, 2023 •

edited

Loading

github-actions bot commented Oct 13, 2023

github-actions bot commented Oct 13, 2023

onkarvhanumante Oct 19, 2023

piotrj-rtbh Oct 19, 2023

onkarvhanumante Oct 19, 2023 •

edited

Loading

piotrj-rtbh Oct 19, 2023 •

edited

Loading

onkarvhanumante Oct 20, 2023

gargcreation1992 Oct 20, 2023 •

edited

Loading

piotrj-rtbh Oct 20, 2023

github-actions bot commented Oct 20, 2023

onkarvhanumante commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

piotrj-rtbh commented Oct 26, 2023 •

edited

Loading

piotrj-rtbh commented Nov 2, 2023

bsardo commented Nov 30, 2023

RTBHouse: native support #3212

RTBHouse: native support #3212

Conversation

piotrj-rtbh commented Oct 13, 2023 • edited Loading

Type of change

Description of change

Other information

github-actions bot commented Oct 13, 2023

Code coverage summary

rtbhouse

github-actions bot commented Oct 13, 2023

Code coverage summary

rtbhouse

onkarvhanumante Oct 19, 2023

Choose a reason for hiding this comment

piotrj-rtbh Oct 19, 2023

Choose a reason for hiding this comment

onkarvhanumante Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

piotrj-rtbh Oct 19, 2023 • edited Loading

Choose a reason for hiding this comment

onkarvhanumante Oct 20, 2023

Choose a reason for hiding this comment

gargcreation1992 Oct 20, 2023 • edited Loading

Choose a reason for hiding this comment

piotrj-rtbh Oct 20, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2023

Code coverage summary

rtbhouse

onkarvhanumante commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

Code coverage summary

rtbhouse

piotrj-rtbh commented Oct 26, 2023 • edited Loading

piotrj-rtbh commented Nov 2, 2023

bsardo commented Nov 30, 2023

piotrj-rtbh commented Oct 13, 2023 •

edited

Loading

onkarvhanumante Oct 19, 2023 •

edited

Loading

piotrj-rtbh Oct 19, 2023 •

edited

Loading

gargcreation1992 Oct 20, 2023 •

edited

Loading

piotrj-rtbh commented Oct 26, 2023 •

edited

Loading