Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome Back: yeahmobi #3228

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Welcome Back: yeahmobi #3228

merged 3 commits into from
Oct 18, 2023

Conversation

SyntaxNode
Copy link
Contributor

@SyntaxNode SyntaxNode commented Oct 17, 2023

Reverting removal of the Yeahmobi adapter. This adapter was remove due to an unreachable email address. They've provided an updated email address which we've verified is actively monitored.

Per #3194 from @solinary06

@SyntaxNode
Copy link
Contributor Author

Please review this PR only from the perspective of reverting the removal commit, updating the email address, and updating the adapter name to match current best practices. Reviews of the code itself is out of scope.

@github-actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 94d6581

yeahmobi

Refer here for heat map coverage report

github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:23:	Builder		100.0%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:35:	MakeRequests	100.0%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:46:	makeRequest	78.6%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:76:	transform	93.8%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:104:	getYeahmobiExt	100.0%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:127:	getEndpoint	100.0%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:132:	MakeBids	100.0%
github.com/prebid/prebid-server/adapters/yeahmobi/yeahmobi.go:170:	getBidType	100.0%
total:									(statements)	95.1%

@bsardo bsardo self-requested a review October 17, 2023 17:45
@bsardo bsardo assigned bsardo, hhhjort and VeronikaSolovei9 and unassigned bsardo Oct 17, 2023
Copy link
Collaborator

@hhhjort hhhjort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SyntaxNode SyntaxNode merged commit 17109ca into prebid:master Oct 18, 2023
5 checks passed
svamiftah pushed a commit to sovrn/prebid-server that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants