New Adapter: Alkimi #3247
Merged
New Adapter: Alkimi #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adapters/alkimi/alkimi_test.go
Outdated
| assert.NotNil(t, bidder) | ||
| } | ||
|
|
||
| func TestMakeRequests(t *testing.T) { |
There was a problem hiding this comment.
@kalidas-alkimi recommended to use JSON framework tests. Should add exemplary and supplemental tests.
Refer following as example,
There was a problem hiding this comment.
fixed
@kalidas-alkimi could you link the added SON framework tests
There was a problem hiding this comment.
I hope this is also a recommendation, we will update it in future.
There was a problem hiding this comment.
I hope this is also a recommendation, we will update it in future.
PBS-GO expects to add json framework tests whenever new adapter gets added
There was a problem hiding this comment.
We don't fully understand, JSON tests are required or not? Should we re-write our unit tests or not?
There was a problem hiding this comment.
I hope this is also a recommendation, we will update it in future.
PBS-GO expects to add json framework tests whenever new adapter gets added
@pro-nsk JSON tests are required
There was a problem hiding this comment.
@onkarvhanumante Added JSON tests
@pro-nsk JSON test is expected to cover code path of MakeRequests and MakeBids. Now that JSON tests are added, could remove following tests.
TestMakeRequests, TestMakeBidsShouldReturnErrorIfResponseBodyContainsIncorrectImp, TestMakeBidsShouldReturnErrorIfResponseBodyContainsIncorrectImp,
TestMakeBidsShouldReturnEmptyListIfBidResponseIsNull,
TestMakeBidsShouldReturnEmptyListIfBidResponseIsError,
TestMakeBidsShouldReturnBidWithResolvedMacros,
TestMakeBidsShouldReturnErrorIfResponseBodyContainsIncorrectImp,
TestMakeBidsShouldReturnEmptyListIfBidResponseIsNull,
TestMakeBidsShouldReturnEmptyListIfBidResponseIsError,
TestMakeBidsShouldReturnBidWithResolvedMacros,
TestMakeBidsShouldReturnBidForAllTypes
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Fixed |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
|
PR checks are failing with following error. Run |
fixed |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Code coverage summaryNote:
alkimiRefer here for heat map coverage report |
Comment on lines
+2
to
+3
| maintainer: | ||
| email: [email protected] |
There was a problem hiding this comment.
@kalidas-alkimi @pro-nsk an email is sent from prebid team to verify above mentioned email address.
Requesting to respond back "received" message
Sonali-More-Xandr
approved these changes
Nov 20, 2023
onkarvhanumante
approved these changes
Nov 20, 2023
svamiftah
pushed a commit
to sovrn/prebid-server
that referenced
this pull request
Nov 21, 2023
co-authored by @kalidas-alkimi @pro-nsk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alkimi adapter already supported on prebid-server-java repo, now added on go repo