Fix: use bidder info fs config as base when merging overrides #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsardo
changed the title
bsardo
changed the title
bsardo
changed the title
… to accommodate env var overrides
VeronikaSolovei9
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way we can fix the bidder info config override logic issue where information in the base config (file system) is lost when override data is provided (pbs.yaml, env vars, etc). This implementation avoids a previously discussed approach of changing bools to bool pointers and instead mimics an approach taken to handle aliases where a nillable fields struct is introduced to assist in detecting the presence of certain fields in an override config.
Some of the team met this morning and agreed to favor this approach over the pointer approach.