Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIDEM: Added use to macros library #3403

Merged
merged 20 commits into from
Jan 23, 2024
Merged

AIDEM: Added use to macros library #3403

merged 20 commits into from
Jan 23, 2024

Conversation

Wazabit
Copy link
Contributor

@Wazabit Wazabit commented Jan 16, 2024

No description provided.

github-actions[bot]
github-actions bot reviewed Jan 16, 2024
View reviewed changes
adapters/aidem/aidem.go Outdated Show resolved Hide resolved
SyntaxNode
SyntaxNode reviewed Jan 16, 2024
View reviewed changes
adapters/aidem/aidem.go Show resolved Hide resolved
adapters/aidem/aidem.go Outdated Show resolved Hide resolved
adapters/aidem/aidem.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, c8d892d

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:21:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:49:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:95:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:107:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:122:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:139:	buildEndpointURL	100.0%
total:								(statements)		84.3%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 4672c73

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:21:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:49:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:95:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:107:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:122:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:139:	buildEndpointURL	100.0%
total:								(statements)		84.3%

@bsardo bsardo changed the title AIDEM Bid Adapter: Added use to macros library AIDEM: Added use to macros library Jan 16, 2024
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 186aa7b

aidem

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:21:	MakeRequests		75.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:49:	MakeBids		94.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:95:	Builder			100.0%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:107:	getMediaTypeForBid	66.7%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:122:	getImpressionExt	71.4%
github.com/prebid/prebid-server/v2/adapters/aidem/aidem.go:139:	buildEndpointURL	100.0%
total:								(statements)		84.3%

gargcreation1992
gargcreation1992 reviewed Jan 22, 2024
View reviewed changes
static/bidder-info/aidem.yaml
@@ -15,5 +15,5 @@ capabilities:
- native
userSync:
redirect:
url: https://gum.aidemsrv.com/prebid_sync?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}
url: https://gum.aidemsrv.com/prebid_sync?gdpr={{.GDPR}}&consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&redirect={{.RedirectURL}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usersync url works. 👍

@Sonali-More-Xandr Sonali-More-Xandr merged commit ae291f9 into prebid:master Jan 23, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jan 23, 2024
Closed
@And1sS And1sS mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxNode SyntaxNode SyntaxNode left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

@gargcreation1992 gargcreation1992 gargcreation1992 approved these changes

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

Assignees

@gargcreation1992 gargcreation1992

@Sonali-More-Xandr Sonali-More-Xandr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Wazabit @SyntaxNode @gargcreation1992 @Sonali-More-Xandr @gsollazzo @darkstarac