ImproveDigital: Bad-Input Error #3469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
improvedigitalRefer here for heat map coverage report |
Code coverage summaryNote:
improvedigitalRefer here for heat map coverage report |
SyntaxNode
changed the title
| @@ -276,7 +276,7 @@ func (a *ImprovedigitalAdapter) getAdditionalConsentProvidersUserExt(request ope | |||
| } | |||
|
|
|||
| // Check key exist user.ext.ConsentedProvidersSettings.consented_providers | |||
| var cpMap = make(map[string]json.RawMessage) | |||
| var cpMap = make(map[string]interface{}) | |||
There was a problem hiding this comment.
Could you please add a json test case for this change.
| @@ -276,7 +276,7 @@ func (a *ImprovedigitalAdapter) getAdditionalConsentProvidersUserExt(request ope | |||
| } | |||
|
|
|||
| // Check key exist user.ext.ConsentedProvidersSettings.consented_providers | |||
| var cpMap = make(map[string]json.RawMessage) | |||
| var cpMap = make(map[string]interface{}) | |||
There was a problem hiding this comment.
@ishihanvcs any particular reason to use interface{} here? this change add step for asserting cMapValue to string (line 291)
consentStr := cpMapValue.(string)
On line 291, adapter code is not checking whether cpMapValue can be asserted into string. This could led to panic at run time. Refer https://go.dev/play/p/BnmZ2ZGjT3E as example
Additionally json.RawMessage does gurantee that value parsed in cpMap will be a valid json which can be converted further into string. But with interface{} cpMap can have any value
| if len(cpStr) == 0 { | ||
| return nil, nil | ||
| } | ||
| //cpStr = consentStr[:len(consentStr)-1] |
There was a problem hiding this comment.
could remove this code comment
|
@onkarvhanumante Thanks for pointing out the issue precisely. As an occasional go developer, I was too hasty to look forward all possible execution path. I'll soon revert Also, I'll add a supplemental test for the multi ~ case in the value of |
Code coverage summaryNote:
improvedigitalRefer here for heat map coverage report |
|
@onkarvhanumante @gargcreation1992 Code updated. Please review & merge if found okay. |
onkarvhanumante
approved these changes
Feb 12, 2024
gargcreation1992
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Forward fix for prebid/prebid-server-java#2942
Original issue is found & reported on pbs java. As the pbs go adapters are continuously being ported to java version, we want to fix this here first and then provide fix in the java version.
Please review & merge kindly at your earliest convenience.
TIA