Sample: fix prebid js loading bug on sample html page #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhongshixi please give this a quick look when you have some time. |
zhongshixi
approved these changes
Oct 22, 2024
zhongshixi
reviewed
Oct 22, 2024
| <script src="//cdn.jsdelivr.net/npm/prebid.js@latest/dist/not-for-prod/prebid.js"></script> | ||
| <script> | ||
| <script src="//cdn.jsdelivr.net/npm/prebid.js@latest/dist/not-for-prod/prebid.js" defer></script> | ||
| <script defer> |
There was a problem hiding this comment.
👍 for adding defer to ensure full html is parsed before running the script + ensure the order of execution of scripts
bsardo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug on sample html page:
This is caused by
appendChild()method call (inside pbjs) on a DOM element that doesn't exist yet .This can be fixed by simply by deferring javascript scripts loading, and that is what i did in this pr.