Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New adapter: Ads Interactive #3929

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

New adapter: Ads Interactive #3929

wants to merge 5 commits into from
+1,708 −0

Conversation

AdsInteractive
Copy link

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 77fe565

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

przemkaczmarek
przemkaczmarek reviewed Oct 10, 2024
View reviewed changes
static/bidder-info/ads_interactive.yaml
@@ -0,0 +1,21 @@
endpoint: "https://bntb.adsintreactive.com/"
maintainer:
email: "[email protected]"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have sent a email, please confirm

przemkaczmarek
przemkaczmarek reviewed Oct 10, 2024
View reviewed changes
static/bidder-info/ads_interactive.yaml Outdated
@@ -0,0 +1,21 @@
endpoint: "https://bntb.adsintreactive.com/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is not reachable:
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, there was an error in the domain, fixed

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ad4f8d5

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 0cc30e3

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

@przemkaczmarek przemkaczmarek self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemkaczmarek przemkaczmarek Awaiting requested review from przemkaczmarek

At least 2 approving reviews are required to merge this pull request.

Assignees

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdsInteractive @przemkaczmarek