Save document issue local date #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 6, 2023 11:21
This will replace the current date field that is used for showing the emission date in generated pdfs and SAFT report generation for the PT module specifically This just adds the field to the entity and makes it accessible for the pdf generation. Currently fallsback to the existing date field in case of no local date value to avoid any problems with upgrading/migrating old data
not the current date This should avoid some weird edge cases for daylight savings months Unlike the export data, there is no fallback tothe current date column since we are querying the data directly from the database and adding a fallback would most likly come with a large performance penalty in an already slow process Also cleanup some unused code from the latest SAFT version generator to facilitate reading and analysis
Vasco-F
reviewed
Jun 7, 2023
| QJPAPTReceiptInvoiceEntity invoice = QJPAPTReceiptInvoiceEntity.jPAPTReceiptInvoiceEntity; | ||
|
|
||
| JPAQuery<PTReceiptInvoiceEntity> query = this.createQuery(); | ||
|
|
||
| query.from(invoice) | ||
| .where(invoice.instanceOf(JPAPTReceiptInvoiceEntity.class).and(invoice.date.between(from, to)) | ||
| .where(invoice.instanceOf(JPAPTReceiptInvoiceEntity.class).and(invoice.localDate.between(from, to)) |
There was a problem hiding this comment.
Just a reminder to ensure the release notes include this constraint regarding SAFT
Vasco-F
reviewed
Jun 7, 2023
| @@ -127,6 +126,9 @@ protected <D extends AbstractDAOPTGenericInvoice<T>> T issue(final T document, f | |||
| + " does not have a series unique code specified")) | |||
| .toString(); | |||
|
|
|||
| ZoneId timezone = document.getBusiness().getTimezone(); | |||
| LocalDate issueLocalDate = document.getLocalDate().orElse(LocalDate.ofInstant(invoiceDate.toInstant(), timezone)); | |||
There was a problem hiding this comment.
Throw exception in these handlers when localDate is null (e.g. DocumentIssuingException)
Do the same for all country handlers
There was a problem hiding this comment.
Per a discussion done in person, the agreed upon approach will be to remove the mandatory check in the generic invoice builder. That will make it so that the field isn't mandatory so we will fill it in with the current local date for the business that is issuing the invoice if no value is provided by the user
Vasco-F
requested changes
Jun 7, 2023
Since we want to provide a default value as we do for the current date field, it make no sense to make this field mandatory
Vasco-F
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.