Add missing options verbify to Pretender prototype. #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this is true it seems like we could use a Would you mind adding that module (with a test that fails the current codebase for OPTIONS)? |
|
I'll check it. The code for OPTIONS do exist but it wasn't exposed like others on the Pretender prototype. |
|
Added some tests. The options call will fail if the options line is not added to Pretender. |
|
@trek This looks good to merge, just wanted your eyes on it to make sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be missing and is required to fake an OPTIONS request in ember-cli-mirage.