-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn on second pretender #178
Conversation
cfdf928
to
87dcbab
Compare
@trek - This was released without a major version bump (as discussed in #165 (comment)) in 1.4.0... 😿 |
@trek Shouldn't the warning be a |
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
@mariogintili @rwjblue I'm down to do a console.warn instead of throw an error release. I opted not to major bump because certain parts of Pretender (proxy and shutdown) will not work if you start a second server before shutting the first one down. It was the existing behavior but it's also a bug and doesn't follow the usage requirement we've had since the first release. I didn't know so many project still relied on this specific bug being left in place. |
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
no issue - a [recent update](pretenderjs/pretender#178) to Pretender contained a breaking change that throws an error when multiple pretender instances exist - using mirage in acceptance tests was [triggering the error](miragejs/ember-cli-mirage#915)
Replaces #156 with a small change.