Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop Node 4 and 5; add Node 10, 11 #241

Merged
merged 1 commit into from
Jan 2, 2019
Merged

drop Node 4 and 5; add Node 10, 11 #241

merged 1 commit into from
Jan 2, 2019

Conversation

givanse
Copy link
Contributor

@givanse givanse commented Jan 2, 2019 •
edited
Loading

Dropping Node 4 and 5 from CI and adding Node 10, it is the most recent LTS.

Yarn is adding the integrity SHAs for the first time, hence the big diff.

This was referenced Jan 2, 2019
Merged
Merged
rwjblue
rwjblue reviewed Jan 2, 2019
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add Node 11 (current stable release)?

@mike-north
Copy link
Member

LGTM, pending addition of node 11

@givanse givanse force-pushed the bump-engines branch 2 times, most recently from e161ad3 to e0a957c Compare January 2, 2019 17:58
@givanse givanse changed the title drop Node 4 and 5; add Node 10 drop Node 4 and 5; add Node 10, 11 Jan 2, 2019
@mike-north mike-north merged commit 2b1dafe into pretenderjs:master Jan 2, 2019
@givanse givanse deleted the bump-engines branch January 2, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@givanse @mike-north @rwjblue