bugfix: iife is 100% backwards compatible #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
givanse
commented
Apr 3, 2019
•
givanse
commented
- ember-cli-pretender can be bumped with no code changes Update Pretender version (^3.0.1) rwjblue/ember-cli-pretender#70
- ember-cli-mirage can ditch the shim and use the ES6 output remove Pretender shim miragejs/ember-cli-mirage#1503
This was referenced Apr 3, 2019
Closed
givanse
commented
Apr 3, 2019
givanse
commented
Apr 3, 2019
givanse
commented
Apr 3, 2019
| "files": [ | ||
| "dist", | ||
| "index.d.ts" | ||
| ], |
There was a problem hiding this comment.
npm publish --dry-run
npm notice 📦 [email protected]
npm notice === Tarball Contents ===
npm notice 2.1kB package.json
npm notice 2.6kB CHANGELOG.md
npm notice 1.0kB index.d.ts
npm notice 1.1kB LICENSE
npm notice 13.0kB README.md
npm notice 16.4kB dist/pretender.es.js
npm notice 18.5kB dist/pretender.js
mike-north
force-pushed
the
backward-compatible
branch
from
81850cf
to
efa3bb6
Compare
mike-north
approved these changes
Apr 4, 2019
| rollup.config.js | ||
| karma.conf.js | ||
| *.md | ||
| yarn.lock |
There was a problem hiding this comment.
Was this file deliberately deleted? If not, please restore it.
There was a problem hiding this comment.
Yeah, intentional, .npmignore (black list) is harder to maintain than to use the files property in package.json (white list).
mike-north
reviewed
Apr 4, 2019
givanse
commented
Apr 4, 2019
|
The other PRs (mirage, e-cli-pretender) still work 👍 Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.