Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: extract hosts #256

Merged
merged 1 commit into from
Apr 20, 2020
Merged

refactor: extract hosts #256

merged 1 commit into from
Apr 20, 2020

Conversation

givanse
Copy link
Contributor

@givanse givanse commented Apr 12, 2019 •
edited
Loading

  • no logic changes
  • extract Hosts to its own class
  • updated a few vars to lets

@givanse givanse mentioned this pull request Apr 28, 2019
Merged
xg-wang
xg-wang reviewed May 5, 2019
View reviewed changes
src/hosts.ts Show resolved Hide resolved
@xg-wang xg-wang merged commit aa631de into pretenderjs:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xg-wang xg-wang xg-wang left review comments

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@givanse @xg-wang