refactor: extract create-passthrough & interceptor #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
givanse
commented
Apr 12, 2019
src/index.ts
Outdated
| // properties to copy from the native xhr to fake xhr | ||
| var lifecycleProps = ['readyState', 'responseText', 'responseXML', 'status', 'statusText']; | ||
|
|
||
| var xhr = fakeXHR._passthroughRequest = new ctx.pretender._nativeXMLHttpRequest(); |
There was a problem hiding this comment.
ctx.pretender._nativeXMLHttpRequest was a closure and now it is an argument for the function.
givanse
changed the title
xg-wang
force-pushed
the
refactor-create-passthrough
branch
from
00aa8f2
to
d9264ea
Compare
xg-wang
force-pushed
the
refactor-create-passthrough
branch
from
d9264ea
to
5450c3a
Compare
xg-wang
force-pushed
the
refactor-create-passthrough
branch
from
5450c3a
to
f73f7bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No business logic changes, just:
createPassthroughto its own fileinterceptorto its own file