Add missing type definitions in index.d.ts #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xg-wang
requested changes
Oct 28, 2019
index.d.ts
Outdated
| public handledRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
| public undhandledRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
| public passtroughRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
| public erroredRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; |
There was a problem hiding this comment.
Suggested change
| public erroredRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | |
| public erroredRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData, error: Error): void; |
index.d.ts
Outdated
| public erroredRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
|
|
||
| public prepareBody(body: string): void; | ||
| public prepareHeaders(headers: object): void; |
There was a problem hiding this comment.
Suggested change
| public prepareHeaders(headers: object): void; | |
| public prepareHeaders(headers: {[k: string]: string}): {[k: string]: string}; |
index.d.ts
Outdated
| public passtroughRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
| public erroredRequest(verb: string, path: string, request: FakeXMLHttpRequest & ExtraRequestData): void; | ||
|
|
||
| public prepareBody(body: string): void; |
There was a problem hiding this comment.
Suggested change
| public prepareBody(body: string): void; | |
| public prepareBody(body: string): string; |
index.d.ts
Outdated
| @@ -32,6 +42,7 @@ export type ResponseData = [number, { [k: string]: string }, string]; | |||
| interface ExtraRequestData { | |||
| params: Params; | |||
| queryParams: QueryParams; | |||
| requestBody: string | |||
There was a problem hiding this comment.
https:/pretenderjs/pretender/blob/v3.0.2/src/index.ts#L396
Pretender only adds params and queryParams. I think this needs to be fixed in fake-xml-http-request package.
There was a problem hiding this comment.
|
Thanks! I think this PR covers all the remaining public APIs mentioned in the readme. |
ohcibi
force-pushed
the
add-missing-members-in-ts-types-definitions
branch
2 times, most recently
from
b055351
to
6033278
Compare
ohcibi
force-pushed
the
add-missing-members-in-ts-types-definitions
branch
from
6033278
to
757ad88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some of the missing type definitions in index.d.ts. I tried creating the declaration
using tsc but apparently another rollup-typescript plugin is necessary for this to work and I wasn't
able to generate a useful declarations file with it, so I added it manually. Fixes #277