Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

Add a prominent deprecation notice #63

Merged
merged 1 commit into from
Apr 9, 2017
Merged

Add a prominent deprecation notice #63

merged 1 commit into from
Apr 9, 2017

Conversation

paulmelnikow
Copy link

@belak has started merging contributions at the original repo! 🚀

So, it's time to deprecate this fork. Here's a prominent notice sending people back to the original.

@belak
Copy link

belak commented Apr 5, 2017

Perhaps the "Upgrading from sorin-ionescu/prezto" section should be removed as well?

@paulmelnikow
Copy link
Author

The notice is pretty hard to miss.

I think those upgrade instructions are useful as historical reference. People who followed them before may come to look for them, wondering, what commands did I run again??

I could add a second clarifying note, if you think folks legitimately will be confused.

@belak
Copy link

belak commented Apr 5, 2017

No I suppose that makes sense. :)

@plessbd
Copy link

plessbd commented Apr 5, 2017

Maybe we should put how to reset back to sorin-ionescu/prezto in the deprecation notice?

cd "${ZDOTDIR:-$HOME}/.zprezto"
git remote set-url origin https:/sorin-ionescu/prezto.git
git pull
git submodule update --init --recursive

Though that might cause conflicts, so we might want to fix that before doing it...

@paulmelnikow
Copy link
Author

Hmmm. I wouldn't expect those instructions to work. They'd preserve the commits from the fork, not to mention cause a million merge conflicts. Have you tested them?

If we can develop some instructions that are tested and safe, I'd love to include them. They could also be added at a later time.

@paulmelnikow
Copy link
Author

Perhaps moving .zprezto to bkp.zprezto and re-cloning would be simplest.

@johnpneumann
Copy link

johnpneumann commented Apr 5, 2017

+1

I agree that we should give some type of indication on how to reset back. Has anyone tried to change the remote repo and just do a git fetch and git reset --hard origin/master

@plessbd
Copy link

plessbd commented Apr 6, 2017

so far i had to move and redo the install myself.

@paulmelnikow
Copy link
Author

A hard reset would risk losing local commits into the ether of the git reflog, as well as losing uncommitted changes. I'd be more comfortable with a backup and reinstall.

@star-szr
Copy link

star-szr commented Apr 7, 2017

Not sure if it's been discussed already, and it would probably break things even more than what's being discussed here for people that have switched to this fork, but…

I think @sorin-ionescu expressed some interest in sorin-ionescu#1239 (comment) toward moving the prezto project to the zsh-users organization.

I like seeing projects that start as a personal repo on GH move to an organization. To me, it's often a sign that the project has some maturity and a community of some kind behind it.

@belak
Copy link

belak commented Apr 7, 2017

I'd like to get this notice in sooner rather than later... once it goes in, someone can open a new PR and debate about the best way for people to migrate back.

@paulmelnikow
Copy link
Author

Agreed. @johnpneumann could you mark it approved? I can't merge it until you do.

@johnpneumann
Copy link

Approved

@paulmelnikow paulmelnikow merged commit d3a768b into prezto-inactive-community-fork:master Apr 9, 2017
@paulmelnikow paulmelnikow deleted the deprecation branch April 9, 2017 16:00
@sorin-ionescu
Copy link

sorin-ionescu commented Apr 14, 2017

@cottser I spoke of my past misdeeds. I don't want to move it at the moment but get long-living issues fixed. I have added contributors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants